Format Rust sources at 100 columns

This commit is contained in:
Samuel Onoja committed 2026-10-22 01:28:03 +01:00
1 parent 4661f595f8
commit 610478f8c7
336 files changed
+23497 -7892

No files matched your search

+49 -14
View File
@@ -114,13 +114,19 @@ impl Matcher {
return None;
}
for (rule, regex) in &self.rules {
if parents.iter().any(|parent| rule.ignore_parents.contains(parent)) {
if parents
.iter()
.any(|parent| rule.ignore_parents.contains(parent))
{
continue;
}
if let Some(captures) = regex.captures(command) {
let mut title = rule.title.clone();
for index in 0..captures.len() {
title = title.replace(&format!("{{{index}}}"), captures.get(index).map_or("", |m| m.as_str()));
title = title.replace(
&format!("{{{index}}}"),
captures.get(index).map_or("", |m| m.as_str()),
);
}
if title.len() > 256 || title.chars().any(char::is_control) {
return None;
@@ -149,14 +155,22 @@ fn validate_rule(rule: &Rule, regex: &Regex) -> Result<(), String> {
if rule.pattern.len() > 2_048
|| rule.min_duration_ms > 60_000
|| !matches!(rule.progress.as_str(), "indeterminate" | "cargo-json")
|| rule.dedupe_by.as_deref().is_some_and(|value| value != "cwd")
|| rule
.dedupe_by
.as_deref()
.is_some_and(|value| value != "cwd")
{
return Err("invalid rule duration, progress adapter or dedupe policy".into());
}
if rule.ignore_parents.len() > 16 || rule.ignore_parents.iter().any(|name| name.len() > 128) {
return Err("too many or too long parent names".into());
}
if rule.icon.len() > 64 || !rule.icon.bytes().all(|b| b.is_ascii_alphanumeric() || b == b'-') {
if rule.icon.len() > 64
|| !rule
.icon
.bytes()
.all(|b| b.is_ascii_alphanumeric() || b == b'-')
{
return Err("invalid symbolic icon".into());
}
let capture = Regex::new(r"\{([^}]+)\}").expect("static pattern");
@@ -201,7 +215,10 @@ impl Settings {
}
fn diagnostic(node: &KdlNode, message: impl std::fmt::Display) -> Error {
Error(format!("activities at byte {}: {message}", node.span().offset()))
Error(format!(
"activities at byte {}: {message}",
node.span().offset()
))
}
pub(crate) fn parse(node: &KdlNode) -> Result<Value, Error> {
@@ -241,7 +258,12 @@ pub(crate) fn parse(node: &KdlNode) -> Result<Value, Error> {
}
let key = name.replace('-', "_");
let parsed = if name == "ignore-parents" {
if property.entries().iter().any(|entry| entry.name().is_some()) || property.entries().is_empty() {
if property
.entries()
.iter()
.any(|entry| entry.name().is_some())
|| property.entries().is_empty()
{
return Err(diagnostic(property, "ignore-parents requires names"));
}
Value::Array(
@@ -252,7 +274,8 @@ pub(crate) fn parse(node: &KdlNode) -> Result<Value, Error> {
.collect::<Result<_, _>>()?,
)
} else {
crate::node_value(property, &key, "rule").map_err(|error| diagnostic(property, error))?
crate::node_value(property, &key, "rule")
.map_err(|error| diagnostic(property, error))?
};
if value.insert(key, parsed).is_some() {
return Err(diagnostic(property, "duplicate rule setting"));
@@ -268,12 +291,15 @@ pub(crate) fn parse(node: &KdlNode) -> Result<Value, Error> {
value
.entry("result")
.or_insert(json!({"ok":"Finished","fail":"Command failed"}));
let rule: Rule = serde_json::from_value(Value::Object(value)).map_err(|error| diagnostic(child, error))?;
let rule: Rule = serde_json::from_value(Value::Object(value))
.map_err(|error| diagnostic(child, error))?;
let settings = Settings {
rules: vec![rule.clone()],
..Default::default()
};
settings.validate().map_err(|error| diagnostic(child, error))?;
settings
.validate()
.map_err(|error| diagnostic(child, error))?;
rules.push(rule);
} else {
if !matches!(
@@ -290,16 +316,24 @@ pub(crate) fn parse(node: &KdlNode) -> Result<Value, Error> {
return Err(diagnostic(child, "unknown activity node"));
}
let field = key.replace('-', "_");
let value = crate::node_value(child, &field, "activities").map_err(|error| diagnostic(child, error))?;
let value = crate::node_value(child, &field, "activities")
.map_err(|error| diagnostic(child, error))?;
if values.insert(field, value).is_some() {
return Err(diagnostic(child, "duplicate activity setting"));
}
}
}
rules.extend(builtins().into_iter().filter(|rule| !names.contains(&rule.name)));
rules.extend(
builtins()
.into_iter()
.filter(|rule| !names.contains(&rule.name)),
);
values.insert("rules".into(), serde_json::to_value(rules).unwrap());
let settings: Settings = serde_json::from_value(Value::Object(values)).map_err(|error| diagnostic(node, error))?;
settings.validate().map_err(|error| diagnostic(node, error))?;
let settings: Settings =
serde_json::from_value(Value::Object(values)).map_err(|error| diagnostic(node, error))?;
settings
.validate()
.map_err(|error| diagnostic(node, error))?;
Ok(serde_json::to_value(settings).unwrap())
}
fn builtins() -> Vec<Rule> {
@@ -371,7 +405,8 @@ mod tests {
"work-minuts 20",
] {
assert!(
crate::Document::parse(&format!("activities {{ pomodoro {{ {invalid}; }}; }}")).is_err(),
crate::Document::parse(&format!("activities {{ pomodoro {{ {invalid}; }}; }}"))
.is_err(),
"{invalid}"
);
}
+35 -7
View File
@@ -2,12 +2,32 @@ use crate::theme::Appearance;
pub use ferese_theme_model::families::{Family, Palette};
pub const BUILTINS: [(&str, &str, &str, &str); 6] = [
("ferese-blue", "Ferese Blue", "ferese-blue-light", "ferese-blue"),
("catppuccin", "Catppuccin", "catppuccin-latte", "catppuccin-mocha"),
(
"ferese-blue",
"Ferese Blue",
"ferese-blue-light",
"ferese-blue",
),
(
"catppuccin",
"Catppuccin",
"catppuccin-latte",
"catppuccin-mocha",
),
("gruvbox", "Gruvbox", "gruvbox-light", "gruvbox"),
("rose-pine", "Rosé Pine", "rose-pine-dawn", "rose-pine-moon"),
("tokyo-night", "Tokyo Night", "tokyo-night-day", "tokyo-night"),
("everforest", "Everforest", "everforest-light", "everforest-dark"),
(
"tokyo-night",
"Tokyo Night",
"tokyo-night-day",
"tokyo-night",
),
(
"everforest",
"Everforest",
"everforest-light",
"everforest-dark",
),
];
pub fn family_id(preset: &str) -> &str {
@@ -19,7 +39,11 @@ pub fn family_id(preset: &str) -> &str {
pub fn variant(id: &str, appearance: Appearance) -> Option<&'static str> {
if let Some(row) = BUILTINS.iter().find(|row| row.0 == id) {
return Some(if appearance == Appearance::Light { row.2 } else { row.3 });
return Some(if appearance == Appearance::Light {
row.2
} else {
row.3
});
}
match (id, appearance) {
("dracula", Appearance::Dark) => Some("dracula"),
@@ -36,8 +60,12 @@ pub fn builtins() -> Vec<Family> {
.map(|(id, name, light, dark)| Family {
id: (*id).into(),
name: (*name).into(),
light: Some(Palette::from(&crate::theme::preset(light, Appearance::Light).unwrap())),
dark: Some(Palette::from(&crate::theme::preset(dark, Appearance::Dark).unwrap())),
light: Some(Palette::from(
&crate::theme::preset(light, Appearance::Light).unwrap(),
)),
dark: Some(Palette::from(
&crate::theme::preset(dark, Appearance::Dark).unwrap(),
)),
})
.collect()
}
+19 -6
View File
@@ -28,7 +28,10 @@ impl ConfigFile {
.join(path.file_name().ok_or("Invalid configuration path")?),
Err(error) => return Err(error.to_string()),
};
let mut lock_name = path.file_name().ok_or("Invalid configuration path")?.to_os_string();
let mut lock_name = path
.file_name()
.ok_or("Invalid configuration path")?
.to_os_string();
lock_name.push(".lock");
let lock = OpenOptions::new()
@@ -40,7 +43,9 @@ impl ConfigFile {
.open(path.with_file_name(lock_name))
.map_err(|e| e.to_string())?;
lock.try_lock().map_err(|error| match error {
fs::TryLockError::WouldBlock => "Configuration is being saved by another app. Please try again.".into(),
fs::TryLockError::WouldBlock => {
"Configuration is being saved by another app. Please try again.".into()
}
fs::TryLockError::Error(error) => error.to_string(),
})?;
@@ -77,7 +82,9 @@ impl ConfigFile {
.map_err(|e| e.to_string())?;
}
staged.write_all(desired.as_bytes()).map_err(|e| e.to_string())?;
staged
.write_all(desired.as_bytes())
.map_err(|e| e.to_string())?;
staged.as_file().sync_all().map_err(|e| e.to_string())?;
validate(staged.path())?;
@@ -86,8 +93,11 @@ impl ConfigFile {
}
if let Some(path) = backup {
let mut previous = tempfile::NamedTempFile::new_in(parent).map_err(|e| e.to_string())?;
previous.write_all(self.source.as_bytes()).map_err(|e| e.to_string())?;
let mut previous =
tempfile::NamedTempFile::new_in(parent).map_err(|e| e.to_string())?;
previous
.write_all(self.source.as_bytes())
.map_err(|e| e.to_string())?;
previous.as_file().sync_all().map_err(|e| e.to_string())?;
previous.persist(path).map_err(|e| e.to_string())?;
}
@@ -187,7 +197,10 @@ mod tests {
let path = directory.path().join("config.kdl");
fs::write(&path, "// initial").unwrap();
let file = ConfigFile::open(&path).unwrap();
assert!(file.replace("// rejected", None, |_| Err("invalid".into())).is_err());
assert!(
file.replace("// rejected", None, |_| Err("invalid".into()))
.is_err()
);
assert_eq!(ConfigFile::open(&path).unwrap().source(), "// initial");
}
}
+171 -52
View File
@@ -66,7 +66,10 @@ pub fn default_wallpaper_for(appearance: theme::Appearance) -> &'static str {
.join(name)
});
path.canonicalize().unwrap_or(path).to_string_lossy().into_owned()
path.canonicalize()
.unwrap_or(path)
.to_string_lossy()
.into_owned()
})
}
@@ -93,7 +96,12 @@ fn is_records(key: &str, parent: &str) -> bool {
(parent, key),
(
"",
"bindings" | "binding_modes" | "window_rules" | "output_profiles" | "autostart" | "panels"
"bindings"
| "binding_modes"
| "window_rules"
| "output_profiles"
| "autostart"
| "panels"
) | ("output_profiles", "outputs")
| ("binding_modes", "bindings")
| ("start" | "center" | "end", "groups")
@@ -105,7 +113,13 @@ fn is_array(key: &str, parent: &str) -> bool {
parent == "commands"
|| matches!(
key,
"command" | "position" | "padding" | "width_presets" | "xkb_options" | "settings_command" | "outputs"
"command"
| "position"
| "padding"
| "width_presets"
| "xkb_options"
| "settings_command"
| "outputs"
)
}
@@ -114,7 +128,9 @@ fn scalar(value: &KdlValue) -> Result<Value, Error> {
KdlValue::String(s) => Value::String(s.clone()),
KdlValue::Bool(v) => Value::Bool(*v),
KdlValue::Null => {
return Err(Error("Omit optional settings instead of using #null".into()));
return Err(Error(
"Omit optional settings instead of using #null".into(),
));
}
KdlValue::Integer(n) => {
if let Ok(n) = i64::try_from(*n) {
@@ -154,7 +170,9 @@ fn object(doc: &KdlDocument, parent: &str) -> Result<Map<String, Value>, Error>
node_value(node, &key, parent)?
};
if is_records(&key, parent) {
let records = result.entry(key).or_insert_with(|| Value::Array(Vec::new()));
let records = result
.entry(key)
.or_insert_with(|| Value::Array(Vec::new()));
records.as_array_mut().unwrap().push(value);
} else {
insert(&mut result, key, value)?;
@@ -166,7 +184,9 @@ fn object(doc: &KdlDocument, parent: &str) -> Result<Map<String, Value>, Error>
fn node_value(node: &KdlNode, key: &str, parent: &str) -> Result<Value, Error> {
if node.ty().is_some() || node.entries().iter().any(|e| e.ty().is_some()) {
return Err(Error("Type annotations are not supported in configuration".into()));
return Err(Error(
"Type annotations are not supported in configuration".into(),
));
}
let args = node
@@ -182,7 +202,11 @@ fn node_value(node: &KdlNode, key: &str, parent: &str) -> Result<Value, Error> {
.collect::<Vec<_>>();
if is_records(key, parent) {
let mut map = node.children().map(|d| object(d, key)).transpose()?.unwrap_or_default();
let mut map = node
.children()
.map(|d| object(d, key))
.transpose()?
.unwrap_or_default();
for (name, entry) in props {
insert(&mut map, name, scalar(entry.value())?)?;
}
@@ -219,7 +243,11 @@ fn node_value(node: &KdlNode, key: &str, parent: &str) -> Result<Value, Error> {
)));
}
let mut map = node.children().map(|d| object(d, key)).transpose()?.unwrap_or_default();
let mut map = node
.children()
.map(|d| object(d, key))
.transpose()?
.unwrap_or_default();
for (name, entry) in props {
insert(&mut map, name, scalar(entry.value())?)?;
}
@@ -245,7 +273,9 @@ pub struct Document {
impl Document {
pub fn parse(source: &str) -> Result<Self, Error> {
let doc = source.parse::<KdlDocument>().map_err(|e| Error(format!("{e:?}")))?;
let doc = source
.parse::<KdlDocument>()
.map_err(|e| Error(format!("{e:?}")))?;
let value = Value::Object(object(&doc, "")?);
Ok(Self { doc, value })
@@ -258,7 +288,8 @@ impl Document {
/// A runtime view; the original KDL remains available for comment-preserving edits.
pub fn with_theme(&self, theme: &theme::ResolvedTheme) -> Self {
let mut document = self.clone();
document.value["theme"] = serde_json::to_value(&theme.tokens).expect("serializable theme tokens");
document.value["theme"] =
serde_json::to_value(&theme.tokens).expect("serializable theme tokens");
document.value["theme"]["appearance"] = serde_json::to_value(theme.appearance).unwrap();
document
}
@@ -317,7 +348,10 @@ impl Document {
pub fn add(&mut self, path: &str, fields: Vec<(String, Value)>) -> Result<(), Error> {
let mut candidate = self.clone();
let (last, parents) = path.rsplit_once('.').map_or((path, ""), |(p, l)| (l, p));
let parent = parents.rsplit('.').find(|s| s.parse::<usize>().is_err()).unwrap_or("");
let parent = parents
.rsplit('.')
.find(|s| s.parse::<usize>().is_err())
.unwrap_or("");
if !is_records(last, parent) {
return Err(Error("Expected a list of records".into()));
@@ -325,12 +359,18 @@ impl Document {
let doc = section_mut(
&mut candidate.doc,
&parents.split('.').filter(|s| !s.is_empty()).collect::<Vec<_>>(),
&parents
.split('.')
.filter(|s| !s.is_empty())
.collect::<Vec<_>>(),
"",
)?;
doc.nodes_mut()
.push(value_node(last, &Value::Object(fields.into_iter().collect()), parent)?);
doc.nodes_mut().push(value_node(
last,
&Value::Object(fields.into_iter().collect()),
parent,
)?);
format_document(&mut candidate.doc);
candidate.refresh()?;
*self = candidate;
@@ -344,11 +384,21 @@ impl Document {
}
if self.get("theme.light").is_some() || self.get("theme.dark").is_some() {
set_in(&mut self.doc, &["theme", "mode"], "", Value::String("dark".into()))?;
set_in(
&mut self.doc,
&["theme", "mode"],
"",
Value::String("dark".into()),
)?;
return self.refresh();
}
let Some(index) = self.doc.nodes().iter().position(|node| node.name().value() == "theme") else {
let Some(index) = self
.doc
.nodes()
.iter()
.position(|node| node.name().value() == "theme")
else {
return Ok(());
};
@@ -356,7 +406,11 @@ impl Document {
let mut moved = Vec::new();
for name in ["colors", "surface", "border", "focus-ring"] {
if let Some(index) = children.nodes().iter().position(|node| node.name().value() == name) {
if let Some(index) = children
.nodes()
.iter()
.position(|node| node.name().value() == name)
{
moved.push(children.nodes_mut().remove(index));
}
}
@@ -367,7 +421,12 @@ impl Document {
}
}
set_in(&mut self.doc, &["theme", "mode"], "", Value::String("dark".into()))?;
set_in(
&mut self.doc,
&["theme", "mode"],
"",
Value::String("dark".into()),
)?;
self.refresh()
}
@@ -388,14 +447,18 @@ impl Document {
let doc = section_mut(
&mut candidate.doc,
&parents.split('.').filter(|s| !s.is_empty()).collect::<Vec<_>>(),
&parents
.split('.')
.filter(|s| !s.is_empty())
.collect::<Vec<_>>(),
"",
)?;
if let Some(index) = doc
.nodes()
.iter()
.position(|node| field(node.name().value(), parents.rsplit('.').next().unwrap_or("")) == name)
{
if let Some(index) = doc.nodes().iter().position(|node| {
field(
node.name().value(),
parents.rsplit('.').next().unwrap_or(""),
) == name
}) {
let node = doc.nodes_mut().remove(index);
let mut comments = String::new();
@@ -423,14 +486,19 @@ impl Document {
let (last, parents) = path.rsplit_once('.').map_or((path, ""), |(p, l)| (l, p));
let doc = section_mut(
&mut candidate.doc,
&parents.split('.').filter(|s| !s.is_empty()).collect::<Vec<_>>(),
&parents
.split('.')
.filter(|s| !s.is_empty())
.collect::<Vec<_>>(),
"",
)?;
let i = doc
.nodes()
.iter()
.enumerate()
.filter(|(_, n)| field(n.name().value(), parents.rsplit('.').next().unwrap_or("")) == last)
.filter(|(_, n)| {
field(n.name().value(), parents.rsplit('.').next().unwrap_or("")) == last
})
.nth(index)
.map(|(i, _)| i)
.ok_or_else(|| Error("This item no longer exists. Reload settings.".into()))?;
@@ -498,7 +566,11 @@ type NodeFormat = (Vec<Option<kdl::KdlEntryFormat>>, Option<String>);
fn collect_node_formats(doc: &KdlDocument, formats: &mut Vec<NodeFormat>) {
for node in doc.nodes() {
let entries = node.entries().iter().map(|entry| entry.format().cloned()).collect();
let entries = node
.entries()
.iter()
.map(|entry| entry.format().cloned())
.collect();
let terminator = node
.format()
.map(|format| format.terminator.clone())
@@ -543,7 +615,11 @@ fn format_document(doc: &mut KdlDocument) {
}
fn node_index(doc: &mut KdlDocument, key: &str, parent: &str) -> usize {
if let Some(i) = doc.nodes().iter().position(|n| field(n.name().value(), parent) == key) {
if let Some(i) = doc
.nodes()
.iter()
.position(|n| field(n.name().value(), parent) == key)
{
return i;
}
@@ -551,7 +627,11 @@ fn node_index(doc: &mut KdlDocument, key: &str, parent: &str) -> usize {
doc.nodes().len() - 1
}
fn section_mut<'a>(doc: &'a mut KdlDocument, parts: &[&str], parent: &str) -> Result<&'a mut KdlDocument, Error> {
fn section_mut<'a>(
doc: &'a mut KdlDocument,
parts: &[&str],
parent: &str,
) -> Result<&'a mut KdlDocument, Error> {
if parts.is_empty() {
return Ok(doc);
}
@@ -606,10 +686,11 @@ fn unset_property(doc: &mut KdlDocument, parts: &[&str], parent: &str) -> Result
return Ok(false);
};
if parts.len() == used + 1
&& let Some(index) = node
.entries()
.iter()
.position(|entry| entry.name().is_some_and(|name| field(name.value(), key) == parts[used]))
&& let Some(index) = node.entries().iter().position(|entry| {
entry
.name()
.is_some_and(|name| field(name.value(), key) == parts[used])
})
{
let entry = node.entries_mut().remove(index);
if let Some(format) = entry.format() {
@@ -660,7 +741,8 @@ fn set_in(doc: &mut KdlDocument, parts: &[&str], parent: &str, value: Value) ->
{
collect_comments(node, &mut comments);
}
doc.nodes_mut().retain(|node| field(node.name().value(), parent) != key);
doc.nodes_mut()
.retain(|node| field(node.name().value(), parent) != key);
if let Some(first) = nodes.first_mut() {
first.set_format(kdl::KdlNodeFormat {
leading: comments,
@@ -732,7 +814,9 @@ fn set_in(doc: &mut KdlDocument, parts: &[&str], parent: &str, value: Value) ->
}
}
if key == "autostart" && rest[0] == "command" && node.children().is_none_or(|d| d.get("command").is_none())
if key == "autostart"
&& rest[0] == "command"
&& node.children().is_none_or(|d| d.get("command").is_none())
{
node.entries_mut().retain(|e| e.name().is_some());
for value in value
@@ -847,9 +931,15 @@ fn value_node(key: &str, value: &Value, parent: &str) -> Result<KdlNode, Error>
{
node.entries_mut().push(KdlEntry::new(kdl_value(value)?));
}
} else if is_records(key, parent) && map.len() <= 4 && !value.is_array() && !value.is_object() {
node.entries_mut()
.push(KdlEntry::new_prop(name.replace('_', "-"), kdl_value(value)?));
} else if is_records(key, parent)
&& map.len() <= 4
&& !value.is_array()
&& !value.is_object()
{
node.entries_mut().push(KdlEntry::new_prop(
name.replace('_', "-"),
kdl_value(value)?,
));
} else {
append(&mut child, name, value, key)?;
}
@@ -871,7 +961,10 @@ fn value_node(key: &str, value: &Value, parent: &str) -> Result<KdlNode, Error>
fn append(doc: &mut KdlDocument, key: &str, value: &Value, parent: &str) -> Result<(), Error> {
if is_records(key, parent) {
for record in value.as_array().ok_or_else(|| Error("Expected records".into()))? {
for record in value
.as_array()
.ok_or_else(|| Error("Expected records".into()))?
{
doc.nodes_mut().push(value_node(key, record, parent)?);
}
} else {
@@ -894,13 +987,22 @@ mod tests {
"binding-mode resize { binding h resize left; binding l resize right; }\nbinding-mode launch { binding t spawn terminal; }\n",
).unwrap();
assert_eq!(document.get("binding_modes.0.name").unwrap(), "resize");
assert_eq!(document.get("binding_modes.1.bindings.0.argument").unwrap(), "terminal");
assert_eq!(
document.get("binding_modes.1.bindings.0.argument").unwrap(),
"terminal"
);
document
.set("binding_modes.0.bindings.0.argument", "up".into())
.unwrap();
let reparsed = super::Document::parse(&document.to_string()).unwrap();
assert_eq!(reparsed.get("binding_modes.0.bindings.0.argument").unwrap(), "up");
assert_eq!(reparsed.get("binding_modes.0.bindings.1.argument").unwrap(), "right");
assert_eq!(
reparsed.get("binding_modes.0.bindings.0.argument").unwrap(),
"up"
);
assert_eq!(
reparsed.get("binding_modes.0.bindings.1.argument").unwrap(),
"right"
);
}
#[test]
fn adopting_appearance_modes_preserves_legacy_colors_and_comments() {
@@ -908,7 +1010,9 @@ mod tests {
"// my desktop\ntheme {\n colors {\n accent \"#123456\" // my accent\n }\n}\n",
)
.unwrap();
document.set("theme.mode", serde_json::json!("light")).unwrap();
document
.set("theme.mode", serde_json::json!("light"))
.unwrap();
assert_eq!(
document.get("theme.dark.colors.accent"),
Some(&serde_json::json!("#123456"))
@@ -931,7 +1035,8 @@ mod tests {
#[test]
fn inline_comments_and_failed_edits_leave_document_intact() {
let mut doc = Document::parse("// header\nanimations {\n speed 0.75 // keep inline\n}\n").unwrap();
let mut doc =
Document::parse("// header\nanimations {\n speed 0.75 // keep inline\n}\n").unwrap();
doc.set("animations.speed", 0.8.into()).unwrap();
assert!(doc.to_string().contains("// keep inline"));
assert_eq!(
@@ -974,11 +1079,15 @@ autostart "program" "two words" enabled=#false
assert_eq!(doc.get("bindings.0.action").unwrap(), "toggle-overview");
doc.set("bindings.0.action", "none".into()).unwrap();
doc.set("input.repeat_rate", 25.into()).unwrap();
doc.set("output_profiles.0.outputs.0.scale", 2.0.into()).unwrap();
doc.set("output_profiles.0.outputs.0.scale", 2.0.into())
.unwrap();
let reparsed = Document::parse(&doc.to_string()).unwrap();
assert_eq!(reparsed.get("bindings.0.action").unwrap(), "none");
assert_eq!(reparsed.get("input.repeat_rate").unwrap(), 25);
assert_eq!(reparsed.get("output_profiles.0.outputs.0.scale").unwrap(), 2.0);
assert_eq!(
reparsed.get("output_profiles.0.outputs.0.scale").unwrap(),
2.0
);
}
#[test]
@@ -987,13 +1096,21 @@ autostart "program" "two words" enabled=#false
"output-profile desk { output match=\"DP-1\" { position 0 0; }; }\ncommands { lock-screen \"locker\"; }\n",
)
.unwrap();
doc.set("output_profiles.0.outputs.0.position", serde_json::json!([100, 200]))
.unwrap();
doc.set("commands.lock-screen", serde_json::json!(["ferese-lock", "--lock"]))
.unwrap();
doc.set(
"output_profiles.0.outputs.0.position",
serde_json::json!([100, 200]),
)
.unwrap();
doc.set(
"commands.lock-screen",
serde_json::json!(["ferese-lock", "--lock"]),
)
.unwrap();
let reparsed = Document::parse(&doc.to_string()).unwrap();
assert_eq!(
reparsed.get("output_profiles.0.outputs.0.position").unwrap(),
reparsed
.get("output_profiles.0.outputs.0.position")
.unwrap(),
&serde_json::json!([100, 200])
);
assert_eq!(
@@ -1023,7 +1140,9 @@ autostart "program" "two words" enabled=#false
serde_json::json!({})
);
}
assert!(Document::parse("panel main { metadata { desktop-widgets \"custom\"; }; }").is_ok());
assert!(
Document::parse("panel main { metadata { desktop-widgets \"custom\"; }; }").is_ok()
);
}
#[test]
+304 -105
View File
@@ -78,17 +78,18 @@ impl Schedule {
AutoSource::System => Ok((
context.system.unwrap_or(Appearance::Dark),
None,
context
.system
.is_none()
.then(|| "System appearance is unavailable. Using Dark until it becomes available.".into()),
context.system.is_none().then(|| {
"System appearance is unavailable. Using Dark until it becomes available."
.into()
}),
)),
AutoSource::Schedule => self
.boundaries(now, zone)
.map(|(appearance, next)| (appearance, Some(next), None)),
AutoSource::SunriseSunset => {
Err("Sunrise/sunset is not available yet; choose Follow system or Custom schedule.".into())
}
AutoSource::SunriseSunset => Err(
"Sunrise/sunset is not available yet; choose Follow system or Custom schedule."
.into(),
),
}
}
@@ -105,7 +106,11 @@ impl Schedule {
}
}
pub fn boundaries(&self, now: Timestamp, zone: &TimeZone) -> Result<(Appearance, Timestamp), String> {
pub fn boundaries(
&self,
now: Timestamp,
zone: &TimeZone,
) -> Result<(Appearance, Timestamp), String> {
let parse = |s: &str| -> Result<Time, String> {
if s.len() != 5 || s.as_bytes()[2] != b':' {
return Err("theme schedule times must use HH:MM".into());
@@ -171,7 +176,9 @@ pub struct Policy {
pub accent: Option<String>,
}
fn deserialize_light_selection<'de, D: serde::Deserializer<'de>>(deserializer: D) -> Result<Selection, D::Error> {
fn deserialize_light_selection<'de, D: serde::Deserializer<'de>>(
deserializer: D,
) -> Result<Selection, D::Error> {
let mut value = Value::deserialize(deserializer)?;
if let Some(object) = value.as_object_mut() {
object.entry("preset").or_insert(json!("ferese-blue-light"));
@@ -264,11 +271,12 @@ pub fn resolve_with_context(
} else {
TimeZone::UTC
};
let (scheduled, next, auto_note) = if policy.mode == Mode::Auto || policy.schedule.source == AutoSource::Schedule {
policy.schedule.resolve(now, &zone, context)?
} else {
(Appearance::Dark, None, None)
};
let (scheduled, next, auto_note) =
if policy.mode == Mode::Auto || policy.schedule.source == AutoSource::Schedule {
policy.schedule.resolve(now, &zone, context)?
} else {
(Appearance::Dark, None, None)
};
let appearance = match policy.mode {
Mode::Light => Appearance::Light,
Mode::Dark => Appearance::Dark,
@@ -300,14 +308,22 @@ pub fn resolve_with_context(
imported.insert(id.clone(), variants);
}
let split = policy.split.unwrap_or_else(|| {
crate::families::family_id(&policy.light.preset) != crate::families::family_id(&policy.dark.preset)
crate::families::family_id(&policy.light.preset)
!= crate::families::family_id(&policy.dark.preset)
});
let single = policy
.family
.as_deref()
.unwrap_or_else(|| crate::families::family_id(&policy.dark.preset));
let mut fallback_note = if policy.mode == Mode::Auto { auto_note } else { None };
for (kind, selection) in [(Appearance::Light, &policy.light), (Appearance::Dark, &policy.dark)] {
let mut fallback_note = if policy.mode == Mode::Auto {
auto_note
} else {
None
};
for (kind, selection) in [
(Appearance::Light, &policy.light),
(Appearance::Dark, &policy.dark),
] {
let family_id = if split {
selection
.family
@@ -316,15 +332,16 @@ pub fn resolve_with_context(
} else {
single
};
let variant = imported
.get(family_id)
.and_then(|pair: &(Option<Tokens>, Option<Tokens>)| {
if kind == Appearance::Light {
pair.0.clone()
} else {
pair.1.clone()
}
});
let variant =
imported
.get(family_id)
.and_then(|pair: &(Option<Tokens>, Option<Tokens>)| {
if kind == Appearance::Light {
pair.0.clone()
} else {
pair.1.clone()
}
});
let custom_variant = variant.is_some();
let mut tokens = if let Some(tokens) = variant {
tokens
@@ -332,7 +349,10 @@ pub fn resolve_with_context(
preset(id, kind)?
} else {
if !imported.contains_key(family_id)
&& !matches!(family_id, "dracula" | "monochrome" | "monokai" | "ayu-light")
&& !matches!(
family_id,
"dracula" | "monochrome" | "monokai" | "ayu-light"
)
{
return Err(format!("Unknown theme family: {family_id}"));
}
@@ -343,7 +363,11 @@ pub fn resolve_with_context(
.map_or(family_id, |family| family.name.as_str());
fallback_note = Some(format!(
"{name} has no {} variant. Using Ferese Blue for this appearance.",
if kind == Appearance::Light { "light" } else { "dark" }
if kind == Appearance::Light {
"light"
} else {
"dark"
}
));
}
preset(
@@ -358,8 +382,8 @@ pub fn resolve_with_context(
if !families.iter().any(|family| family.id == family_id) {
let light = crate::families::variant(family_id, Appearance::Light)
.and_then(|id| preset(id, Appearance::Light).ok());
let dark =
crate::families::variant(family_id, Appearance::Dark).and_then(|id| preset(id, Appearance::Dark).ok());
let dark = crate::families::variant(family_id, Appearance::Dark)
.and_then(|id| preset(id, Appearance::Dark).ok());
families.push(crate::families::Family {
id: family_id.into(),
name: family_id.into(),
@@ -372,12 +396,16 @@ pub fn resolve_with_context(
let authored_accent = tokens.colors.accent.clone();
let preset_end = (!custom_variant)
.then(|| {
let id = crate::families::variant(family_id, kind).unwrap_or(if kind == Appearance::Light {
"ferese-blue-light"
} else {
"ferese-blue"
});
crate::presets::PRESETS.iter().find(|preset| preset.id == id)
let id = crate::families::variant(family_id, kind).unwrap_or(
if kind == Appearance::Light {
"ferese-blue-light"
} else {
"ferese-blue"
},
);
crate::presets::PRESETS
.iter()
.find(|preset| preset.id == id)
})
.flatten()
.map(|preset| preset.gradient_end)
@@ -402,7 +430,11 @@ pub fn resolve_with_context(
let layer = Document::parse(&source).map_err(|e| format!("{}: {e}", path.display()))?;
let layer = layer.get("theme").unwrap_or(layer.value());
for role in ["surface_raised", "application_background"] {
if layer.get("colors").and_then(|colors| colors.get(role)).is_some() {
if layer
.get("colors")
.and_then(|colors| colors.get(role))
.is_some()
{
explicit_surfaces.insert(role);
}
}
@@ -419,7 +451,11 @@ pub fn resolve_with_context(
tokens = serde_json::from_value(value).map_err(|e| e.to_string())?;
for layer in [&root, &Value::Object(overrides.clone())] {
for role in ["surface_raised", "application_background"] {
if layer.get("colors").and_then(|colors| colors.get(role)).is_some() {
if layer
.get("colors")
.and_then(|colors| colors.get(role))
.is_some()
{
explicit_surfaces.insert(role);
}
}
@@ -430,25 +466,35 @@ pub fn resolve_with_context(
} else {
[1.; 4]
};
if tokens.colors.surface_base != authored_base && !explicit_surfaces.contains("surface_raised") {
if tokens.colors.surface_base != authored_base
&& !explicit_surfaces.contains("surface_raised")
{
tokens.colors.surface_raised = hex(blend(base, shade, 0.055));
}
if tokens.colors.surface_base != authored_base && !explicit_surfaces.contains("application_background") {
if tokens.colors.surface_base != authored_base
&& !explicit_surfaces.contains("application_background")
{
tokens.colors.application_background = hex(blend(base, shade, 0.025));
}
if let Some(accent) = &policy.accent {
tokens.colors.accent = accent.clone();
}
for path in [&mut tokens.background.path, &mut tokens.background.lock_path]
.into_iter()
.flatten()
for path in [
&mut tokens.background.path,
&mut tokens.background.lock_path,
]
.into_iter()
.flatten()
{
*path = theme_path(directory, path);
}
validate(&tokens)?;
let requested_accent = tokens.colors.accent.clone();
transform(&mut tokens, &policy.accessibility, &mut warnings);
resolve_gradients(&mut tokens, preset_end.filter(|_| requested_accent == authored_accent));
resolve_gradients(
&mut tokens,
preset_end.filter(|_| requested_accent == authored_accent),
);
let theme = ResolvedTheme {
appearance: kind,
tokens,
@@ -471,7 +517,11 @@ pub fn resolve_with_context(
theme: selected.expect("selected appearance"),
warnings,
files: all_files,
next_transition: if policy.mode == Mode::Auto { next } else { None },
next_transition: if policy.mode == Mode::Auto {
next
} else {
None
},
families,
fallback_note,
})
@@ -513,7 +563,12 @@ pub fn validate_overrides(document: &Document) -> Result<(), String> {
let mut tokens = token_value(&default_tokens())?;
merge(&mut tokens, root, "", true)?;
for selection in [&policy.light, &policy.dark] {
merge(&mut tokens, &Value::Object(selection.overrides.clone()), "", false)?;
merge(
&mut tokens,
&Value::Object(selection.overrides.clone()),
"",
false,
)?;
}
Ok(())
}
@@ -562,7 +617,10 @@ fn merge(target: &mut Value, layer: &Value, prefix: &str, inline: bool) -> Resul
}
pub fn preset(name: &str, appearance: Appearance) -> Result<Tokens, String> {
if let Some(preset) = crate::presets::PRESETS.iter().find(|preset| preset.id == name) {
if let Some(preset) = crate::presets::PRESETS
.iter()
.find(|preset| preset.id == name)
{
if preset.appearance != appearance {
return Err(format!("Preset {name} does not support {appearance:?}"));
}
@@ -640,7 +698,10 @@ pub fn authored_warnings(tokens: &Tokens) -> Vec<String> {
let surfaces = [
("surface-base", &tokens.colors.surface_base),
("surface-raised", &tokens.colors.surface_raised),
("application-background", &tokens.colors.application_background),
(
"application-background",
&tokens.colors.application_background,
),
];
let check = |foreground: &str, background: &str, minimum: f64| {
let foreground = rgba(foreground).unwrap();
@@ -685,7 +746,9 @@ fn validate(tokens: &Tokens) -> Result<(), String> {
}
Value::Number(n) => {
let n = n.as_f64().ok_or("invalid theme number")?;
if !n.is_finite() || (path != ".shadow.soft.offset_y" && !path.ends_with(".angle") && n < 0.) {
if !n.is_finite()
|| (path != ".shadow.soft.offset_y" && !path.ends_with(".angle") && n < 0.)
{
return Err(format!("Invalid theme value {path}"));
}
if (path.ends_with("opacity") || path.ends_with("tint_strength")) && n > 1. {
@@ -735,7 +798,9 @@ fn transform(t: &mut Tokens, accessibility: &Accessibility, warnings: &mut Vec<S
.fold(f64::INFINITY, f64::min)
};
let choose = |preserve_foreground: bool| {
let acceptable = |color| score(color) >= 3. && (!preserve_foreground || contrast(preferred, color) >= 4.5);
let acceptable = |color| {
score(color) >= 3. && (!preserve_foreground || contrast(preferred, color) >= 4.5)
};
if acceptable(requested) {
return Some(requested);
}
@@ -759,7 +824,11 @@ fn transform(t: &mut Tokens, accessibility: &Accessibility, warnings: &mut Vec<S
});
t.colors.accent = hex(adjusted);
t.colors.on_accent = hex(readable(preferred, adjusted, 4.5));
let minimum = if accessibility.increase_contrast { 7. } else { 4.5 };
let minimum = if accessibility.increase_contrast {
7.
} else {
4.5
};
let body = [surface, backgrounds[2], backgrounds[3]];
let bar = [backgrounds[1]; 3];
for (label, color, backgrounds) in [
@@ -784,7 +853,11 @@ fn transform(t: &mut Tokens, accessibility: &Accessibility, warnings: &mut Vec<S
}
}
if accessibility.increase_contrast {
t.colors.border = hex(readable_across(rgba(&t.colors.border).unwrap(), &backgrounds, 3.));
t.colors.border = hex(readable_across(
rgba(&t.colors.border).unwrap(),
&backgrounds,
3.,
));
if backgrounds
.iter()
.any(|background| contrast(rgba(&t.colors.border).unwrap(), *background) < 3.)
@@ -818,7 +891,12 @@ fn resolve_gradients(tokens: &mut Tokens, preset_end: Option<&str>) {
rgba(&tokens.surface.bar.background).unwrap(),
];
for (paint, color, endpoint, focus) in [
(&mut tokens.focus_ring, &tokens.colors.accent, preset_end, true),
(
&mut tokens.focus_ring,
&tokens.colors.accent,
preset_end,
true,
),
(&mut tokens.border, &tokens.colors.border, None, false),
] {
if paint.style == PaintStyle::Solid {
@@ -865,7 +943,8 @@ fn resolve_material_contrast(tokens: &mut Tokens, minimum: f64) {
.map(|step| initial + (1. - initial) * f64::from(step) / 100.)
.find(|opacity| {
let bounds = material_bounds(surface, *opacity);
readable(&[bounds[0], bounds[1], raised, app]) && readable(&material_bounds(bar, *opacity))
readable(&[bounds[0], bounds[1], raised, app])
&& readable(&material_bounds(bar, *opacity))
})
.unwrap_or(1.0);
tokens.material.opacity = tokens.material.opacity.max(opacity);
@@ -883,12 +962,20 @@ fn resolve_material_contrast(tokens: &mut Tokens, minimum: f64) {
}
}
pub type ImportedFamily = (crate::families::Family, (Option<Tokens>, Option<Tokens>), Vec<String>);
pub type ImportedFamily = (
crate::families::Family,
(Option<Tokens>, Option<Tokens>),
Vec<String>,
);
pub fn import_family(id: &str, source: &str) -> Result<ImportedFamily, String> {
let document = Document::parse(source).map_err(|e| e.to_string())?;
let root = document.get("theme").unwrap_or(document.value());
let name = root.get("name").and_then(Value::as_str).unwrap_or(id).to_owned();
let name = root
.get("name")
.and_then(Value::as_str)
.unwrap_or(id)
.to_owned();
let mut variants = [None, None];
let mut warnings = vec![];
for (index, (key, appearance)) in [("light", Appearance::Light), ("dark", Appearance::Dark)]
@@ -907,7 +994,11 @@ pub fn import_family(id: &str, source: &str) -> Result<ImportedFamily, String> {
let mut value = token_value(&base)?;
merge(&mut value, layer, "", false)?;
let mut tokens: Tokens = serde_json::from_value(value).map_err(|e| e.to_string())?;
if layer.get("colors").and_then(|colors| colors.get("border")).is_none() {
if layer
.get("colors")
.and_then(|colors| colors.get("border"))
.is_none()
{
// A new family without an authored border follows its own foreground,
// rather than inheriting the unrelated Ferese Blue border.
let mut border = rgba(&tokens.colors.text_primary)?;
@@ -920,9 +1011,16 @@ pub fn import_family(id: &str, source: &str) -> Result<ImportedFamily, String> {
}
}
if variants.iter().all(Option::is_none) {
return Err("A theme file must declare a light and/or dark section; partial palettes are allowed.".into());
return Err(
"A theme file must declare a light and/or dark section; partial palettes are allowed."
.into(),
);
}
for key in root.as_object().ok_or("Theme file must be a section")?.keys() {
for key in root
.as_object()
.ok_or("Theme file must be a section")?
.keys()
{
if !matches!(key.as_str(), "name" | "light" | "dark") {
return Err(format!("Unknown theme token: {key}"));
}
@@ -946,9 +1044,12 @@ mod tests {
"theme {{ geometry {{ shell-radius {requested}; window-radius 7.25; }} }}"
))
.unwrap();
let result = super::resolve(&document, std::path::Path::new("/tmp"), jiff::Timestamp::now(), |_| {
Err("unexpected theme file".into())
})
let result = super::resolve(
&document,
std::path::Path::new("/tmp"),
jiff::Timestamp::now(),
|_| Err("unexpected theme file".into()),
)
.unwrap();
assert_eq!(result.theme.tokens.geometry.shell_radius, expected);
assert_eq!(result.theme.tokens.geometry.window_radius, 7.25);
@@ -1047,7 +1148,11 @@ mod tests {
];
assert_eq!(
gradient.to,
hex(readable_across(rgba(preset.gradient_end).unwrap(), &backgrounds, 3.))
hex(readable_across(
rgba(preset.gradient_end).unwrap(),
&backgrounds,
3.
))
);
assert!(
backgrounds
@@ -1078,8 +1183,10 @@ mod tests {
assert!(from[0] > from[1] && from[1] > from[2]);
assert!(to[0] > to[1] && to[1] > to[2]);
let document =
Document::parse("theme { family custom; custom-themes { custom { file \"custom.kdl\"; }; }; }").unwrap();
let document = Document::parse(
"theme { family custom; custom-themes { custom { file \"custom.kdl\"; }; }; }",
)
.unwrap();
let theme = resolve(
&document,
Path::new("/config"),
@@ -1118,12 +1225,18 @@ mod tests {
);
assert!(theme.tokens.border.gradient.is_none());
let source = source.replace("family catppuccin", "family catppuccin\nfocus-ring { style solid; }");
let source = source.replace(
"family catppuccin",
"family catppuccin\nfocus-ring { style solid; }",
);
let theme = candidate(&source).unwrap().theme;
assert!(theme.tokens.focus_ring.gradient.is_none());
assert_eq!(theme.tokens.focus_ring.style, PaintStyle::Solid);
assert!(candidate("theme { focus-ring { style rainbow; }; }").is_err());
assert!(candidate("theme { focus-ring { gradient { from \"bad\"; to \"#FFFFFF\"; }; }; }").is_err());
assert!(
candidate("theme { focus-ring { gradient { from \"bad\"; to \"#FFFFFF\"; }; }; }")
.is_err()
);
}
#[test]
@@ -1153,7 +1266,13 @@ mod tests {
assert_eq!(middle.tokens.focus_ring.style, PaintStyle::Auto);
assert!(middle.tokens.focus_ring.gradient.is_some());
assert_eq!(from.transition(&to, 1.), to);
assert!(to.transition(&from, 0.5).tokens.focus_ring.gradient.is_some());
assert!(
to.transition(&from, 0.5)
.tokens
.focus_ring
.gradient
.is_some()
);
}
#[test]
@@ -1168,20 +1287,39 @@ mod tests {
authored_warnings(&tokens)
);
let source = match entry.appearance {
Appearance::Light => format!("theme {{ mode \"light\"; light {{ preset \"{}\"; }}; }}", entry.id),
Appearance::Dark => format!("theme {{ mode \"dark\"; dark {{ preset \"{}\"; }}; }}", entry.id),
Appearance::Light => format!(
"theme {{ mode \"light\"; light {{ preset \"{}\"; }}; }}",
entry.id
),
Appearance::Dark => format!(
"theme {{ mode \"dark\"; dark {{ preset \"{}\"; }}; }}",
entry.id
),
};
let resolved = candidate(&source).unwrap().theme;
assert_eq!(resolved.tokens.colors.border, tokens.colors.border);
assert_eq!(resolved.tokens.colors.surface_raised, tokens.colors.surface_raised);
assert_eq!(
resolved.tokens.colors.surface_raised,
tokens.colors.surface_raised
);
assert_eq!(
resolved.tokens.colors.application_background,
tokens.colors.application_background
);
assert!(authored_warnings(&resolved.tokens).is_empty(), "{}", entry.id);
assert!(
authored_warnings(&resolved.tokens).is_empty(),
"{}",
entry.id
);
}
let dark: Vec<_> = PRESETS.iter().filter(|p| p.appearance == Appearance::Dark).collect();
let light: Vec<_> = PRESETS.iter().filter(|p| p.appearance == Appearance::Light).collect();
let dark: Vec<_> = PRESETS
.iter()
.filter(|p| p.appearance == Appearance::Dark)
.collect();
let light: Vec<_> = PRESETS
.iter()
.filter(|p| p.appearance == Appearance::Light)
.collect();
assert_eq!(dark.len(), 6);
assert_eq!(light.len(), 6);
for (dark, light) in dark.iter().zip(light) {
@@ -1209,7 +1347,12 @@ mod tests {
entry.id
);
let result = candidate(&source).unwrap();
assert!(result.warnings.is_empty(), "{}: {:?}", entry.id, result.warnings);
assert!(
result.warnings.is_empty(),
"{}: {:?}",
entry.id,
result.warnings
);
let theme = result.theme;
assert!(authored_warnings(&theme.tokens).is_empty(), "{}", entry.id);
if increase {
@@ -1218,9 +1361,15 @@ mod tests {
&theme.tokens.colors.surface_raised,
&theme.tokens.colors.application_background,
] {
for foreground in [&theme.tokens.colors.text_primary, &theme.tokens.colors.text_muted] {
for foreground in [
&theme.tokens.colors.text_primary,
&theme.tokens.colors.text_muted,
] {
assert!(
contrast(rgba(foreground).unwrap(), rgba(background).unwrap()) >= 7.,
contrast(
rgba(foreground).unwrap(),
rgba(background).unwrap()
) >= 7.,
"{}: {foreground} on {background}",
entry.id
);
@@ -1262,13 +1411,17 @@ mod tests {
let resolved = candidate(r#"theme { mode "light"; family "catppuccin"; split #true; light { family "gruvbox"; }; dark { family "everforest"; }; }"#).unwrap();
assert_eq!(
resolved.theme.tokens.colors.surface_base,
preset("gruvbox-light", Appearance::Light).unwrap().colors.surface_base
preset("gruvbox-light", Appearance::Light)
.unwrap()
.colors
.surface_base
);
}
#[test]
fn single_variant_families_use_an_explicit_default_fallback() {
let resolved = candidate(r#"theme { mode "light"; family "dracula"; split #false; }"#).unwrap();
let resolved =
candidate(r#"theme { mode "light"; family "dracula"; split #false; }"#).unwrap();
assert_eq!(
resolved.theme.tokens.colors.surface_base,
preset("ferese-blue-light", Appearance::Light)
@@ -1283,7 +1436,8 @@ mod tests {
.iter()
.any(|family| family.id == "dracula" && family.light.is_none())
);
let resolved = candidate(r#"theme { mode "dark"; family "dracula"; split #false; }"#).unwrap();
let resolved =
candidate(r#"theme { mode "dark"; family "dracula"; split #false; }"#).unwrap();
assert!(resolved.fallback_note.is_none());
assert_eq!(resolved.theme.tokens.colors.surface_base, "#282A36");
}
@@ -1376,7 +1530,8 @@ mod tests {
#[test]
fn system_auto_is_context_driven_and_has_no_polling_deadline() {
let document = Document::parse(r#"theme { mode "auto"; schedule { source "system"; }; }"#).unwrap();
let document =
Document::parse(r#"theme { mode "auto"; schedule { source "system"; }; }"#).unwrap();
for appearance in [Appearance::Light, Appearance::Dark] {
let resolved = resolve_with_context(
&document,
@@ -1392,7 +1547,13 @@ mod tests {
assert!(resolved.next_transition.is_none());
assert!(resolved.fallback_note.is_none());
}
let unavailable = resolve(&document, Path::new("/tmp"), Timestamp::now(), |_| unreachable!()).unwrap();
let unavailable = resolve(
&document,
Path::new("/tmp"),
Timestamp::now(),
|_| unreachable!(),
)
.unwrap();
assert!(unavailable.fallback_note.unwrap().contains("unavailable"));
}
@@ -1446,7 +1607,11 @@ mod tests {
light_at: "01:30".into(),
..schedule
};
for now in ["2026-11-01T05:30:00Z", "2026-11-01T06:00:00Z", "2026-11-01T06:30:00Z"] {
for now in [
"2026-11-01T05:30:00Z",
"2026-11-01T06:00:00Z",
"2026-11-01T06:30:00Z",
] {
let (appearance, next) = schedule.boundaries(now.parse().unwrap(), &zone).unwrap();
assert_eq!(appearance, Appearance::Light);
assert_eq!(next, "2026-11-02T00:00:00Z".parse::<Timestamp>().unwrap());
@@ -1459,15 +1624,20 @@ mod tests {
"theme { file \"themes/shared.kdl\"; light { file \"themes/light.kdl\"; }; mode \"light\"; }",
)
.unwrap();
let result = resolve(&doc, Path::new("/config/ferese"), Timestamp::now(), |path| {
match path.to_str().unwrap() {
let result = resolve(
&doc,
Path::new("/config/ferese"),
Timestamp::now(),
|path| match path.to_str().unwrap() {
"/config/ferese/themes/shared.kdl" => {
Ok("colors { accent \"#12AABB\"; text-primary \"#182234\"; }".into())
}
"/config/ferese/themes/light.kdl" => Ok("theme { colors { accent \"#315090\"; }; }".into()),
"/config/ferese/themes/light.kdl" => {
Ok("theme { colors { accent \"#315090\"; }; }".into())
}
_ => panic!("wrong relative path"),
}
})
},
)
.unwrap();
assert_eq!(result.theme.requested_accent, "#315090");
assert_eq!(result.theme.tokens.colors.text_primary, "#182234");
@@ -1516,10 +1686,13 @@ mod tests {
.contains("future_token")
);
assert!(
import_family("bad", "theme { light { geometry { top-bar-radius 8; }; }; }")
.err()
.unwrap()
.contains("geometry.top_bar_radius")
import_family(
"bad",
"theme { light { geometry { top-bar-radius 8; }; }; }"
)
.err()
.unwrap()
.contains("geometry.top_bar_radius")
);
assert!(
import_family("bad", "theme { name Test; future-token 1; light {}; }")
@@ -1549,7 +1722,9 @@ mod tests {
) >= 4.5
);
if increase {
assert!(contrast(rgba(&tokens.colors.text_primary).unwrap(), surface) >= 7.);
assert!(
contrast(rgba(&tokens.colors.text_primary).unwrap(), surface) >= 7.
);
}
if reduce {
assert_eq!(tokens.material.style, "solid");
@@ -1565,8 +1740,12 @@ mod tests {
#[test]
fn transition_text_remains_readable_at_fixed_steps_on_composited_surfaces() {
use crate::presets::PRESETS;
let darks = PRESETS.iter().filter(|entry| entry.appearance == Appearance::Dark);
let lights = PRESETS.iter().filter(|entry| entry.appearance == Appearance::Light);
let darks = PRESETS
.iter()
.filter(|entry| entry.appearance == Appearance::Dark);
let lights = PRESETS
.iter()
.filter(|entry| entry.appearance == Appearance::Light);
for (dark_entry, light_entry) in darks.zip(lights) {
let dark = candidate(&format!(
r#"theme {{ mode "dark"; dark {{ preset "{}"; }}; material {{ style "translucent"; }}; }}"#,
@@ -1585,9 +1764,13 @@ mod tests {
for step in 1..20 {
let frame = from.transition(to, f64::from(step) / 20.);
let mut surface = rgba(&frame.tokens.colors.surface_base).unwrap();
surface[3] = frame.tokens.material.opacity * frame.tokens.material.tint_strength;
surface[3] =
frame.tokens.material.opacity * frame.tokens.material.tint_strength;
let surface = composite(surface, backdrop);
for text in [&frame.tokens.colors.text_primary, &frame.tokens.colors.text_muted] {
for text in [
&frame.tokens.colors.text_primary,
&frame.tokens.colors.text_muted,
] {
assert!(
contrast(rgba(text).unwrap(), surface) >= 4.5,
"step {step}: {text}, contrast {}",
@@ -1598,7 +1781,10 @@ mod tests {
&frame.tokens.colors.surface_raised,
&frame.tokens.colors.application_background,
] {
for text in [&frame.tokens.colors.text_primary, &frame.tokens.colors.text_muted] {
for text in [
&frame.tokens.colors.text_primary,
&frame.tokens.colors.text_muted,
] {
assert!(
contrast(rgba(text).unwrap(), rgba(background).unwrap()) >= 4.5,
"native app step {step}: {text} on {background}"
@@ -1606,13 +1792,17 @@ mod tests {
}
}
let mut bar = rgba(&frame.tokens.surface.bar.background).unwrap();
bar[3] = frame.tokens.material.opacity * frame.tokens.material.tint_strength;
bar[3] =
frame.tokens.material.opacity * frame.tokens.material.tint_strength;
let bar = composite(bar, backdrop);
for text in [
&frame.tokens.surface.bar.text_primary,
&frame.tokens.surface.bar.text_muted,
] {
assert!(contrast(rgba(text).unwrap(), bar) >= 4.5, "bar step {step}: {text}");
assert!(
contrast(rgba(text).unwrap(), bar) >= 4.5,
"bar step {step}: {text}"
);
}
assert!(
contrast(
@@ -1670,8 +1860,16 @@ mod tests {
assert_eq!(from.transition(&from, p), from);
let frame = from.transition(&to, p);
assert_eq!(frame.tokens.material.opacity, from.tokens.material.opacity);
let low = from.tokens.material.tint_strength.min(to.tokens.material.tint_strength);
let high = from.tokens.material.tint_strength.max(to.tokens.material.tint_strength);
let low = from
.tokens
.material
.tint_strength
.min(to.tokens.material.tint_strength);
let high = from
.tokens
.material
.tint_strength
.max(to.tokens.material.tint_strength);
assert!((low..=high).contains(&frame.tokens.material.tint_strength));
}
}
@@ -1692,9 +1890,10 @@ mod tests {
#[test]
fn reduced_motion_cuts_and_policy_does_not_follow_brightness() {
let mut light = candidate("theme { mode \"light\"; colors { surface-base \"#111111\"; }; }")
.unwrap()
.theme;
let mut light =
candidate("theme { mode \"light\"; colors { surface-base \"#111111\"; }; }")
.unwrap()
.theme;
assert_eq!(light.appearance, Appearance::Light);
light.reduced_motion = true;
assert_eq!(default_theme().transition(&light, 0.), light);
+69 -26
View File
@@ -10,7 +10,8 @@ fn removed_panel_surface_fields_are_rejected() {
"style continuous;",
"style islands;",
] {
let document = ferese_config::Document::parse(&format!("panel main {{ {source} }}")).unwrap();
let document =
ferese_config::Document::parse(&format!("panel main {{ {source} }}")).unwrap();
assert!(
serde_json::from_value::<Vec<Panel>>(document.get("panels").unwrap().clone()).is_err(),
"{source}"
@@ -26,9 +27,11 @@ fn panel_surfaces_round_trip_without_group_overrides() {
let panel = &panels[0];
assert_eq!(panel.group_surface(), GroupSurface::Island);
assert_eq!(panel.preset(), Some(PanelStyle::Floating));
doc.set("panels", serde_json::to_value(&panels).unwrap()).unwrap();
doc.set("panels", serde_json::to_value(&panels).unwrap())
.unwrap();
let restored = ferese_config::Document::parse(&doc.to_string()).unwrap();
let restored: Vec<Panel> = serde_json::from_value(restored.get("panels").unwrap().clone()).unwrap();
let restored: Vec<Panel> =
serde_json::from_value(restored.get("panels").unwrap().clone()).unwrap();
assert_eq!(restored, panels);
assert!(doc.to_string().contains("// keep"));
let mut preset = panel.clone();
@@ -77,7 +80,10 @@ animations { speed 0.8; }
validate(&panels).unwrap();
assert_eq!(panels[0].end.groups[0].padding, [2, 3]);
assert!(panels[0].background_opacity.is_none());
assert_eq!(panels[0].end.groups[0].items[0].overflow, OverflowPolicy::Always);
assert_eq!(
panels[0].end.groups[0].items[0].overflow,
OverflowPolicy::Always
);
doc.set("panels.0.end.groups.0.items.0.overflow", "never".into())
.unwrap();
let path = "panels.0.end.groups.0.items";
@@ -102,13 +108,18 @@ animations { speed 0.8; }
panels[0].item(&ItemId("network".into())).unwrap().overflow,
OverflowPolicy::Never
);
assert_eq!(parsed.get("animations.speed").unwrap(), &serde_json::json!(0.8));
assert_eq!(
parsed.get("animations.speed").unwrap(),
&serde_json::json!(0.8)
);
let value = serde_json::to_value(&panels).unwrap();
doc.set("panels", value.clone()).unwrap();
let round_trip = ferese_config::Document::parse(&doc.to_string()).unwrap();
let restored: Vec<Panel> = serde_json::from_value(round_trip.get("panels").unwrap().clone()).unwrap();
let restored: Vec<Panel> =
serde_json::from_value(round_trip.get("panels").unwrap().clone()).unwrap();
assert_eq!(restored, panels);
doc.set(path, Vec::<serde_json::Value>::new().into()).unwrap();
doc.set(path, Vec::<serde_json::Value>::new().into())
.unwrap();
assert!(doc.to_string().contains("// network comment"));
let restored: Vec<Panel> = serde_json::from_value(doc.get("panels").unwrap().clone()).unwrap();
assert!(restored[0].end.groups[0].items.is_empty());
@@ -117,8 +128,10 @@ animations { speed 0.8; }
#[test]
fn panel_border_defaults_off_and_round_trips_an_explicit_enabled_value() {
let mut doc =
ferese_config::Document::parse("panel main { end { group status { item clock kind=clock; }; }; }\n").unwrap();
let mut doc = ferese_config::Document::parse(
"panel main { end { group status { item clock kind=clock; }; }; }\n",
)
.unwrap();
let panels: Vec<Panel> = serde_json::from_value(doc.get("panels").unwrap().clone()).unwrap();
assert!(!panels[0].border);
doc.set("panels.0.border", true.into()).unwrap();
@@ -131,7 +144,8 @@ fn panel_border_defaults_off_and_round_trips_an_explicit_enabled_value() {
#[test]
fn panel_background_opacity_inherits_until_overridden_and_validates_bounds() {
let doc = ferese_config::Document::parse("panel main { end { group status { }; }; }").unwrap();
let mut panels: Vec<Panel> = serde_json::from_value(doc.get("panels").unwrap().clone()).unwrap();
let mut panels: Vec<Panel> =
serde_json::from_value(doc.get("panels").unwrap().clone()).unwrap();
assert_eq!(panels[0].background_opacity, None);
assert!(
serde_json::to_value(&panels[0]).unwrap()["end"]["groups"][0]
@@ -155,14 +169,21 @@ fn panel_edge_defaults_to_top_and_round_trips_both_positions() {
("edge top;", Edge::Top),
("edge bottom;", Edge::Bottom),
] {
let document = ferese_config::Document::parse(&format!("panel main {{ {source} }}")).unwrap();
let panels: Vec<Panel> = serde_json::from_value(document.get("panels").unwrap().clone()).unwrap();
let document =
ferese_config::Document::parse(&format!("panel main {{ {source} }}")).unwrap();
let panels: Vec<Panel> =
serde_json::from_value(document.get("panels").unwrap().clone()).unwrap();
validate(&panels).unwrap();
assert_eq!(panels[0].edge, expected);
let restored: Vec<Panel> = serde_json::from_value(serde_json::to_value(&panels).unwrap()).unwrap();
let restored: Vec<Panel> =
serde_json::from_value(serde_json::to_value(&panels).unwrap()).unwrap();
assert_eq!(restored[0].edge, expected);
let mut moved = panels[0].clone();
moved.edge = if expected == Edge::Top { Edge::Bottom } else { Edge::Top };
moved.edge = if expected == Edge::Top {
Edge::Bottom
} else {
Edge::Top
};
assert!(!moved.same_composition(&panels[0]));
}
}
@@ -177,7 +198,9 @@ fn validation_rejects_duplicate_ids_and_unsupported_surface_configuration() {
assert!(validate(std::slice::from_ref(&panel)).is_err());
assert!(validate(&[]).is_err());
assert!(validate(&[panel.clone(), panel]).is_err());
assert!(ferese_config::from_str::<serde_json::Value>("panel \"main\" { edge \"bottom\"; }").is_ok());
assert!(
ferese_config::from_str::<serde_json::Value>("panel \"main\" { edge \"bottom\"; }").is_ok()
);
let doc = ferese_config::Document::parse("panel \"main\" { edge \"left\"; }").unwrap();
assert!(serde_json::from_value::<Vec<Panel>>(doc.get("panels").unwrap().clone()).is_err());
}
@@ -189,13 +212,18 @@ fn workspace_styles_round_trip_and_only_apply_to_workspaces() {
style.key()
);
let document = ferese_config::Document::parse(&source).unwrap();
let panels: Vec<Panel> = serde_json::from_value(document.get("panels").unwrap().clone()).unwrap();
let panels: Vec<Panel> =
serde_json::from_value(document.get("panels").unwrap().clone()).unwrap();
validate(&panels).unwrap();
assert_eq!(panels[0].start.groups[0].items[0].kind, ItemKind::Workspaces { style });
assert_eq!(
panels[0].start.groups[0].items[0].kind,
ItemKind::Workspaces { style }
);
let mut wrong_kind = serde_json::to_value(&panels[0].start.groups[0].items[0]).unwrap();
wrong_kind["kind"] = "clock".into();
assert!(serde_json::from_value::<Item>(wrong_kind).is_err());
let restored: Vec<Panel> = serde_json::from_value(serde_json::to_value(&panels).unwrap()).unwrap();
let restored: Vec<Panel> =
serde_json::from_value(serde_json::to_value(&panels).unwrap()).unwrap();
assert_eq!(restored, panels);
}
let mut item = serde_json::json!({"id": "spaces", "kind": "workspaces"});
@@ -214,8 +242,13 @@ fn item_options_are_strict_and_metadata_is_explicit() {
for key in ["ovreflow", "visibile", "custom_note"] {
let mut value = serde_json::json!({"id":"network", "kind":"network"});
value[key] = "always".into();
let error = serde_json::from_value::<Item>(value).unwrap_err().to_string();
assert!(error.contains(key) && error.contains("unknown field"), "{error}");
let error = serde_json::from_value::<Item>(value)
.unwrap_err()
.to_string();
assert!(
error.contains(key) && error.contains("unknown field"),
"{error}"
);
}
let source = "panel main { start { group nav { item network kind=\"network\" { metadata { custom-note \"keep\"; overflow \"authored note\"; }; }; }; }; }";
let panel: Vec<Panel> = serde_json::from_value(
@@ -234,8 +267,10 @@ fn item_options_are_strict_and_metadata_is_explicit() {
*item
);
assert!(
serde_json::from_value::<Item>(serde_json::json!({"id":"network", "kind":"network", "metadata":"wrong"}))
.is_err()
serde_json::from_value::<Item>(
serde_json::json!({"id":"network", "kind":"network", "metadata":"wrong"})
)
.is_err()
);
}
@@ -247,16 +282,24 @@ fn activities_are_first_class_items_in_every_zone_and_keep_overflow_settings() {
"panel main {{ style {style}; {zone} {{ group tasks {{ item builds kind=activities priority=20 overflow=always; }}; }}; }}"
);
let mut doc = ferese_config::Document::parse(&source).unwrap();
let panels: Vec<Panel> = serde_json::from_value(doc.get("panels").unwrap().clone()).unwrap();
let panels: Vec<Panel> =
serde_json::from_value(doc.get("panels").unwrap().clone()).unwrap();
ferese_panel::validate(&panels).unwrap();
let parsed = match zone {
"start" => &panels[0].start,
"center" => &panels[0].center,
_ => &panels[0].end,
};
assert_eq!(parsed.groups[0].items[0].kind, ferese_panel::ItemKind::Activities);
assert_eq!(parsed.groups[0].items[0].overflow, ferese_panel::OverflowPolicy::Always);
doc.set("panels", serde_json::to_value(&panels).unwrap()).unwrap();
assert_eq!(
parsed.groups[0].items[0].kind,
ferese_panel::ItemKind::Activities
);
assert_eq!(
parsed.groups[0].items[0].overflow,
ferese_panel::OverflowPolicy::Always
);
doc.set("panels", serde_json::to_value(&panels).unwrap())
.unwrap();
let restored = ferese_config::Document::parse(&doc.to_string()).unwrap();
assert_eq!(restored.get("panels"), doc.get("panels"));
}