From ad1207b417d9876c1c7a169d6939b3dc7a35313f Mon Sep 17 00:00:00 2001
From: Samuel Onoja <samiodev@icloud.com>
Date: Sat, 24 Oct 2026 22:03:23 +0100
Subject: [PATCH] test(settings): detect muted text against its rendered
 background

The previous brightness cutoff rejected visible muted glyphs. Compare against the local background and resolved text colors, retaining the minimum ink count. Verified against the previous toolkit and with a hidden-label negative control.
---
 shell/ferese-settings/src/scroll_tests.rs | 38 ++++++++++++++++++-----
 1 file changed, 31 insertions(+), 7 deletions(-)

diff --git a/shell/ferese-settings/src/scroll_tests.rs b/shell/ferese-settings/src/scroll_tests.rs
index d34350a..f5b61ac 100644
--- a/shell/ferese-settings/src/scroll_tests.rs
+++ b/shell/ferese-settings/src/scroll_tests.rs
@@ -560,6 +560,7 @@ fn gpu_panel_text_survives_preview_clipping_and_scrolling() {
                         scale,
                         theme.cosmic().bg_color().into(),
                     );
+                    let palette = visuals::Palette::from_resolved(&app.resolved.presented);
                     for (label, rect, clip) in labels.labels {
                         let clip = clip.unwrap_or(bounds);
                         if rect.width <= 0.
@@ -571,7 +572,7 @@ fn gpu_panel_text_survives_preview_clipping_and_scrolling() {
                         {
                             continue;
                         }
-                        let mut ink = 0;
+                        let mut colors = std::collections::HashMap::<[u8; 3], usize>::new();
                         for y in (rect.y * scale).ceil() as u32
                             ..((rect.y + rect.height) * scale).floor() as u32
                         {
@@ -579,14 +580,37 @@ fn gpu_panel_text_survives_preview_clipping_and_scrolling() {
                                 ..((rect.x + rect.width) * scale).floor() as u32
                             {
                                 let index = ((y * physical.width + x) * 4) as usize;
-                                if pixels[index..index + 3]
-                                    .iter()
-                                    .any(|channel| *channel > 140)
-                                {
-                                    ink += 1;
-                                }
+                                let rgb = pixels[index..index + 3].try_into().unwrap();
+                                *colors.entry(rgb).or_default() += 1;
                             }
                         }
+                        // The most common color is the local background. Compare
+                        // against the actual text palette so muted glyphs count,
+                        // while a blank label fails on both dark and light surfaces.
+                        let background = *colors.iter().max_by_key(|(_, count)| *count).unwrap().0;
+                        let distance = |color: [u8; 3]| {
+                            color
+                                .into_iter()
+                                .zip(background)
+                                .map(|(a, b)| a.abs_diff(b))
+                                .max()
+                                .unwrap()
+                        };
+                        let threshold = [palette.text, palette.muted]
+                            .into_iter()
+                            .map(|color| {
+                                let [r, g, b, _] = color.into_rgba8();
+                                distance([r, g, b])
+                            })
+                            .min()
+                            .unwrap()
+                            .saturating_div(2)
+                            .max(1);
+                        let ink: usize = colors
+                            .into_iter()
+                            .filter(|(color, _)| distance(*color) >= threshold)
+                            .map(|(_, count)| count)
+                            .sum();
                         assert!(
                             ink > 12,
                             "missing panel text {label:?}: state={selection} width={width} scale={scale} offset={offset} bounds={rect:?}"