The hidden-window sweep built a Vec of cloned Window handles purely to
work around the borrow checker: unmap_elem needs &mut self.space while
the iteration borrows self.window_ids. Move the space out with
mem::take instead and unmap in place, dropping the allocation and the
per-window clone.
Behaviour is unchanged. unmap_elem only removes the element passed to
it, so it cannot affect element_location for any other window, which
makes checking each window immediately before its own unmap equivalent
to testing every hidden window up front; the unmap order is the same
window_ids iteration order. The |= is deliberate so the check never
short-circuits past an unmap.
This is a cleanup, not a measured win. The sweep is dominated by the
linear scans inside element_location and unmap_elem, and a Vec only
allocated when windows were actually hidden, so the saving is small.
Verified with twelve live foot windows across forty workspace switches.
A let-chain collapse in the status menu left the battery blocks
inside the notifications arm, so the percentage, level meter, power
mode row, and power actions only rendered when notifications were
present. Close the notifications block before the battery checks so
each menu kind owns its own sections again.
Use center_x/center_y on the fixed-size icon containers rather than
align_x/align_y, which left badges and the top bar slot sitting off
center in libcosmic, and constrain the menu icon to a square 22px slot
so the battery glyph is not letterboxed by its own width. Give the
power tiles a Fill-width centering container inside their
FillPortion(1) buttons so the label and icon stay centered on hover.
Drop the two column-alignment TODO wrappers the collapse introduced.
visual_scale_for_window returns 1.0 whenever Overview is not
presenting, so gate the window_under_visual walk behind
is_presenting() and read the scale straight from the constant.
Use hash_map::Entry for the window geometry insert so client_size is
only computed on the vacant path, and reuse the elapsed time already
sampled for the frame in expire_wait and presentation_size_request
instead of calling start_time.elapsed() a second time.
Split ScrollingLayout validation so the per-frame geometry solve only
checks scalars and keeps the full tree validation behind debug_assert,
removing a HashSet build from every frame. Replace the per-region Vec
in decode_regions with a stack array via as_chunks, and skip the window
hit test in PointerMotion when Overview is not presenting, where
visual_scale_for_window returns 1.0 regardless.
Guard sync_window_stacking behind a check that the space already matches
the target order with uniform z_index, avoiding an O(n^2) raise_element
loop on every redraw. Narrow window_under_visual to the space iterator
outside Overview, keeping the collected and sorted candidate list for
the Overview branch where front-to-back order is load-bearing.
Raise rust-version to 1.98 and clear the resulting Clippy findings
across the workspace: let-chain collapses, clamp, and while-let loops.
Keep notification actions and dismiss controls visible, compact and animate history, and add themed icon controls and grouping.
Include notification settings, session integration and documentation, on-demand workspaces, and performance baseline notes.
Add compact branded Settings with safe atomic edits, external config refresh and a draggable sidebar. Reconcile services, update connected displays and input devices, apply live layout policy and window rules, and resolve initial floating placement before tiled insertion. Package the Settings launcher and shared Ferese icon.
Render a tinted, scrollable workspace strip with live thumbnails, output-scaled font labels and a subtle selected-workspace outline. Keep the window grid background-free and support workspace selection without exiting overview.
Animate strip opacity independently with precise fade tolerances and continuous reversal, and expose toggle-overview through feresectl.
Samuel Onoja